chore: simplify snapshotForAI to return string with mode option#39755
Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom Mar 18, 2026
Merged
chore: simplify snapshotForAI to return string with mode option#39755pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman merged 1 commit intomicrosoft:mainfrom
Conversation
Push the full/incremental decision into snapshotForAI so callers
get a single string back instead of a {full, incremental?} tuple.
Add mode: 'full' | 'incremental' parameter to control which
snapshot is returned while preserving tracking state.
dgozman
approved these changes
Mar 18, 2026
|
|
||
| ### option: Page.snapshotForAI.mode | ||
| * since: v1.59 | ||
| - `mode` <[string]> |
Member
Author
There was a problem hiding this comment.
You' make it enum as you add the literal :)
Contributor
Test results for "MCP"5507 passed, 343 skipped Merge workflow run. |
Contributor
Test results for "tests 1"6 flaky38822 passed, 845 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
snapshotForAI()now returnsstringinstead of{ full, incremental? }tuplemode: 'full' | 'incremental'parameter to control which snapshot is returnedariaSnapshotDifffromTabSnapshot— the caller passes the desired mode and gets back the right snapshot directlytrackparameter still maintains incremental state;modecontrols what's returned