fix: add missing <string> and <vector> includes to HostPlatformColor.h#2889
Open
Saadnajmi wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: add missing <string> and <vector> includes to HostPlatformColor.h#2889Saadnajmi wants to merge 1 commit intomicrosoft:mainfrom
Saadnajmi wants to merge 1 commit intomicrosoft:mainfrom
Conversation
|
Saadnajmi
changed the title
tido64
reviewed
Apr 7, 2026
Member
tido64
left a comment
tido64
left a comment
There was a problem hiding this comment.
This adds a lot more than just the #includes. Doesn't seem intentional?
Collaborator
Author
No, the branch has extra commits. L I'll go fix that |
Saadnajmi
force-pushed
the
snajmi/fix-missing-string-header
branch
from
13aa05c to
e6d85a9
Compare
HostPlatformColor.h uses std::string (in ColorWithSystemEffect and createSemanticColor) and std::vector but did not include the corresponding headers, causing build failures when this header is included before any other header that transitively pulls them in. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Saadnajmi
force-pushed
the
snajmi/fix-missing-string-header
branch
from
e6d85a9 to
693103e
Compare
tido64
approved these changes
Apr 7, 2026
Saadnajmi
changed the title
Saadnajmi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HostPlatformColor.husesstd::string(inColorWithSystemEffectstruct andcreateSemanticColordeclaration) andstd::vector<std::string>but did not include the<string>or<vector>headers.PointerHoverTracker.cpp).#include <string>and#include <vector>.Test plan
🤖 Generated with Claude Code