Do not invalidate cached model for ContentChangedEvent#3291
Merged
JiuqingSong merged 1 commit intomasterfrom Feb 27, 2026
Merged
Do not invalidate cached model for ContentChangedEvent#3291JiuqingSong merged 1 commit intomasterfrom
JiuqingSong merged 1 commit intomasterfrom
Conversation
JiuqingSong
requested review from
BryanValverdeU,
flyingbee2012,
ianeli1,
juliaroldi and
vinguyen12
juliaroldi
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today everytime we got a ContentChangedEvent that does not have a model object in it, we will clear model cache. We do this because if some old plugin code made change to editor content and trigger this event, it means the model is not matching the DOM. But actually we have MutationObserver to help us detect the DOM change and refresh/invalidate cache, so no need to clear cache for the event specifically.
The motivation of this change is that I found an issue that if an entity is inserted not directly under root level, and then it triggers this event, cache is cleared, next time when we render, we need to rebuild the parent nodes for the entity, which somehow can cause the entity to be reloaded since its parent node got changed.