Fix log forging vulnerability in GetCorrelationVector#373
Merged
Fix log forging vulnerability in GetCorrelationVector#373
GetCorrelationVector#373Conversation
Sanitize MS-CV header value by removing newline characters to prevent malicious users from injecting fake log entries. Added comprehensive unit tests to verify the sanitization logic. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…hub.com/microsoft/teams.net into next/fix-log-forging-correlation-vector
Updated the correlation vector sanitization to use Environment.NewLine as recommended by CodeQL/OWASP. Updated corresponding unit tests to be platform-agnostic by using Environment.NewLine instead of hardcoded newline characters. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Changed GetCorrelationVector to consistently return string.Empty instead of null when the correlation vector header is missing or empty. Updated test to reflect this behavior change. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
rido-min
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Addresses CodeQL security warning: user-provided MS-CV header values were logged without sanitization, allowing
malicious users to inject fake log entries via newline characters.
🤖 Generated with Claude Code