[PA bug fix] use incomming activity's serviceUrl if not set in outgoing activity.#374
Merged
[PA bug fix] use incomming activity's serviceUrl if not set in outgoing activity.#374
serviceUrl if not set in outgoing activity.#374Conversation
singhk97
changed the title
serviceUrl if not set in outgoing activity.
Fixed two instances where AddBotAuthentication overloads were called with parameters in the wrong order: - Line 39: The sectionName-based overload was passing parameters as (schemeName, clientId, tenantId, logger) instead of the correct (clientId, tenantId, schemeName, logger) - Line 59: The IServiceCollection overload had the same parameter ordering issue This ensures that clientId, tenantId, and schemeName are passed to the correct parameter positions, preventing authentication configuration errors. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
rido-min
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft.Teams.Bot.Compat, IfserviceUrlis not set in outgoing activity then use the one from the incomming activity as fallbackConversationAccount.GetAgentIdentity()public. It's being used in the compat adapter.