Use WaitForExitAsync from polyfill#7460
Merged
Youssef1313 merged 3 commits intomicrosoft:mainfrom Feb 25, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes conditional compilation for .NET Standard 2.0 by leveraging the Polyfill package to provide WaitForExitAsync for all target frameworks. The change simplifies the codebase by eliminating the platform-specific workaround that was needed for .NET Standard 2.0.
Changes:
- Removed
#if !NETSTANDARD2_0and#elseconditional compilation blocks that handledProcess.WaitForExitAsyncdifferently for .NET Standard 2.0 - Unified the code path to use
WaitForExitAsyncwith cancellation token across all target frameworks
src/Platform/Microsoft.Testing.Extensions.HangDump/Helpers/IProcessExtensions.cs
Outdated
Show resolved
Hide resolved
…ocessExtensions.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Youssef1313
reviewed
Feb 24, 2026
src/Platform/Microsoft.Testing.Extensions.HangDump/Helpers/IProcessExtensions.cs
Show resolved
Hide resolved
nohwnd
approved these changes
Feb 25, 2026
nohwnd
approved these changes
Feb 25, 2026
Evangelink
pushed a commit
that referenced
this pull request
Mar 2, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.