Accept diffs where the only difference is quotes#3177
Merged
RyanCavanaugh merged 1 commit intomicrosoft:mainfrom Mar 20, 2026
Merged
Accept diffs where the only difference is quotes#3177RyanCavanaugh merged 1 commit intomicrosoft:mainfrom
RyanCavanaugh merged 1 commit intomicrosoft:mainfrom
Conversation
jakebailey
approved these changes
Mar 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the submodule “accepted diffs” list and adds corresponding .diff baseline files so that submodule test runs treat quote-style-only output changes (single vs double quotes) as accepted, aligning Corsa emit with the original source quote style.
Changes:
- Add an “Improved quote style fidelity” section to
testdata/submoduleAccepted.txtenumerating newly-accepted submodule diff baselines. - Add accepted diff baseline files under
testdata/baselines/reference/submoduleAccepted/compiler/for compiler test outputs. - Add accepted diff baseline files under
testdata/baselines/reference/submoduleAccepted/conformance/for conformance test outputs.
Reviewed changes
Copilot reviewed 1 out of 136 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| testdata/submoduleAccepted.txt | Adds a new section listing quote-style-only diffs to treat as accepted submodule diffs. |
| testdata/baselines/reference/submoduleAccepted/compiler/assignmentToConditionalBrandedStringTemplateOrMapping.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/callSignatureFunctionOverload.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/callbackArgsDifferByOptionality.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/coAndContraVariantInferences.js.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/conditionalTypeDiscriminatingLargeUnionRegularTypeFetchingSpeedReasonable.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/consistentAliasVsNonAliasRecordBehavior.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/constantOverloadFunction.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/constantOverloadFunctionNoSubtypeError.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/contextualTypeBasedOnIntersectionWithAnyInTheMix3.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/contextuallyTypedSymbolNamedProperties.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/controlFlowAliasedDiscriminants.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/correlatedUnions.js.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/correlatedUnions.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/declarationEmitAliasInlineing.js.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/declarationEmitAliasInlineing.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/declarationEmitClassMemberWithComputedPropertyName.js.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/declarationEmitJsReExportDefault.js.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/deferredLookupTypeResolution.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/destructuredDeclarationEmit.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/discriminableUnionWithIntersectedMembers.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/discriminantPropertyCheck.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/discriminatedUnionWithIndexSignature.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/excessPropertyCheckIntersectionWithRecursiveType.errors.txt.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/excessPropertyCheckIntersectionWithRecursiveType.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/excessPropertyCheckWithMultipleDiscriminants.errors.txt.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/forwardRefInTypeDeclaration(strict=false).types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/forwardRefInTypeDeclaration(strict=true).types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/genericObjectSpreadResultInSwitch.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/indexedAccessTypeConstraints.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/indexedAccessWithFreshObjectLiteral.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/inferFromGenericFunctionReturnTypes3.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/inferFromNestedSameShapeTuple.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/inferenceOfNullableObjectTypesWithCommonBase.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/intersectionTypeNormalization.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/invariantGenericErrorElaboration.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/jsFileMethodOverloads.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/jsdocBracelessTypeTag1.errors.txt.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/jsdocBracelessTypeTag1.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/jsxIntrinsicDeclaredUsingTemplateLiteralTypeSignatures.errors.txt.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/jsxIntrinsicElementsCompatability.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/mappedTypeContextualTypesApplied.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/mappedTypeGenericIndexedAccess.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/narrowingByTypeofInSwitch.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/narrowingNoInfer1.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/narrowingTypeofDiscriminant.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/narrowingUnionWithBang.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/nestedExcessPropertyChecking.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/neverAsDiscriminantType(strict=false).types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/neverAsDiscriminantType(strict=true).types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/objectLiteralComputedNameNoDeclarationError.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/overloadOnConstAsTypeAnnotation.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/overloadOnConstConstraintChecks1.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/overloadOnConstConstraintChecks2.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/overloadOnConstConstraintChecks3.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/overloadOnConstConstraintChecks4.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/overloadOnConstDuplicateOverloads1.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/overloadOnConstInBaseWithBadImplementationInDerived.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/overloadOnConstInCallback1.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/overloadOnConstInObjectLiteralImplementingAnInterface.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/overloadOnConstInheritance1.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/overloadOnConstInheritance2.errors.txt.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/overloadOnConstInheritance2.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/overloadOnConstInheritance3.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/overloadOnConstInheritance4.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/overloadOnConstNoAnyImplementation.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/overloadOnConstNoAnyImplementation2.errors.txt.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/overloadOnConstNoAnyImplementation2.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/overloadOnConstNoNonSpecializedSignature.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/overloadOnConstNoStringImplementation.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/overloadOnConstNoStringImplementation2.errors.txt.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/overloadOnConstNoStringImplementation2.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/overloadingOnConstants1.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/overloadingOnConstantsInImplementation.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/ramdaToolsNoInfinite2.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/recursiveConditionalTypes.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/specializedOverloadWithRestParameters.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/specializedSignatureAsCallbackParameter1.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/spreadOfParamsFromGeneratorMakesRequiredParams.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/spreadsAndContextualTupleTypes.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/spuriousCircularityOnTypeImport.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/typePredicatesCanNarrowByDiscriminant.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/typeVariableConstraintIntersections.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/typeofImportInstantiationExpression.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/compiler/undefinedAsDiscriminantWithUnknown(strictnullchecks=true).types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/ambientErrors.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/assignmentCompatWithDiscriminatedUnion.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/commonTypeIntersection.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/constAssertions.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/controlFlowAliasing.errors.txt.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/controlFlowAliasing.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/controlFlowGenericTypes.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/controlFlowOptionalChain.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/dependentDestructuredVariables.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/destructuringParameterDeclaration8.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/discriminatedUnionTypes2.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/es2018IntlAPIs.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/es2020IntlAPIs.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/generatorReturnContextualType.errors.txt.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/generatorReturnContextualType.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/independentPropertyVariance.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/intersectionIncludingPropFromGlobalAugmentation.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/intersectionMemberOfUnionNarrowsCorrectly.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/intrinsicTypes.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsUniqueSymbolUsage.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/keyofAndIndexedAccess.js.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/logicalAssignment2(target=es2015).types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/logicalAssignment2(target=es2020).types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/logicalAssignment2(target=es2021).types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/logicalAssignment2(target=esnext).types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/mappedTypeConstraints.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/mappedTypeProperties.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/memberFunctionsWithPrivateOverloads.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/memberFunctionsWithPublicOverloads.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/memberFunctionsWithPublicPrivateOverloads.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/narrowExceptionVariableInCatchClause.errors.txt.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/narrowExceptionVariableInCatchClause.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/override2.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/parserOverloadOnConstants1.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/primtiveTypesAreIdentical.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/specializedSignatureIsNotSubtypeOfNonSpecializedSignature.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/specializedSignatureIsSubtypeOfNonSpecializedSignature.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/staticPropertyNameConflicts(target=es2015,usedefineforclassfields=false).types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/staticPropertyNameConflicts(target=es2015,usedefineforclassfields=true).types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/stringLiteralType.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/stringLiteralTypesInImplementationSignatures.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/subtypingWithCallSignaturesWithSpecializedSignatures.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/subtypingWithConstructSignaturesWithSpecializedSignatures.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/switchWithConstrainedTypeVariable.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/templateLiteralTypes2.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/templateLiteralTypes3.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/typeTagOnPropertyAssignment.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/typedefMultipleTypeParameters.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/typesWithSpecializedCallSignatures.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/typesWithSpecializedConstructSignatures.types.diff | Accepted diff baseline (quote style fidelity). |
| testdata/baselines/reference/submoduleAccepted/conformance/unionTypeReduction2.types.diff | Accepted diff baseline (quote style fidelity). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spot checked these and in all cases, the originating source file had the same quote style as the new Corsa emit