Open
Conversation
Author
|
@microsoft-github-policy-service agree |
* Fixes a bug in the Go watcher where an initial build was skipped if no files were initially modified, causing a hang when the configuration resulted in an empty source file list (missing diagnostic TS18002). * Added regression test for empty files list in watch mode.
JaskiratAnand
force-pushed
the
fix/tsconfig-no-files
branch
from
2fd496c to
9cab0cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When running
tsgo --watchwith atsconfig.jsoncontaining an empty files array and no include rules, the compiler hung silently instead of reportingTS18002("The 'files' list in config file... is empty").This happened because the watcher polling loop (
internal/execute/watcher.go) only triggered a build whenhasBeenModifiedwastrue. On the first cycle,prevModifiedwas empty, so no files appeared modified — skipping the initial build entirely and swallowing the diagnostic.Solution
Treat the first execution cycle (
w.prevModified == nil) as a modified event, ensuring the initial build always runs and configuration diagnostics are emitted correctly.Changes
internal/execute/watcher.go— force initial build on first cyclewatch with empty files list in tsconfigVerification
tscbehavior in watch mode (which correctly reports the diagnostic)npx hereby testpassesFixes #3014