Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repository’s “accepted submodule diffs” list and reference diff artifacts to account for baseline changes where _jsxFileName is now emitted as an absolute /.src/... path (and aligns one legacy script emit with the upstream baseline).
Changes:
- Add a new “_jsxFileName path” section to
testdata/submoduleAccepted.txtand list the newly accepted.js.diffbaselines. - Add/record accepted baseline diffs for
react-jsxdevoutputs where_jsxFileNamechanges from a bare filename to an absolute/.src/...path. - Align
commentsOnJSXExpressionsArePreserved(...moduledetection=legacy)emit diff with the upstream baseline (script emit uses_jsxDEVand is intentionally not a module).
Reviewed changes
Copilot reviewed 1 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| testdata/submoduleAccepted.txt | Adds an accepted-diffs section for _jsxFileName absolute-path baseline deltas. |
| testdata/baselines/reference/submoduleAccepted/compiler/commentsOnJSXExpressionsArePreserved(jsx=react-jsxdev,module=commonjs,moduledetection=auto).js.diff | Accepts _jsxFileName absolute-path baseline change. |
| testdata/baselines/reference/submoduleAccepted/compiler/commentsOnJSXExpressionsArePreserved(jsx=react-jsxdev,module=commonjs,moduledetection=legacy).js.diff | Accepts _jsxFileName absolute-path change and reflects upstream script emit shape. |
| testdata/baselines/reference/submoduleAccepted/compiler/commentsOnJSXExpressionsArePreserved(jsx=react-jsxdev,module=commonjs,moduledetection=force).js.diff | Accepts _jsxFileName absolute-path baseline change. |
| testdata/baselines/reference/submoduleAccepted/compiler/jsxEmptyExpressionNotCountedAsChild(jsx=react-jsxdev).js.diff | Accepts _jsxFileName absolute-path baseline change. |
| testdata/baselines/reference/submoduleAccepted/compiler/jsxRuntimePragma(jsx=react-jsxdev).js.diff | Accepts _jsxFileName absolute-path baseline change in multiple emitted sections. |
| testdata/baselines/reference/submoduleAccepted/compiler/reactImportUnusedInNewJSXEmit(jsx=react-jsxdev).js.diff | Accepts _jsxFileName absolute-path baseline change. |
| testdata/baselines/reference/submoduleAccepted/conformance/jsxJsxsCjsTransformChildren(jsx=react-jsxdev).js.diff | Accepts _jsxFileName absolute-path baseline change. |
| testdata/baselines/reference/submoduleAccepted/conformance/jsxJsxsCjsTransformCustomImport(jsx=react-jsxdev).js.diff | Accepts _jsxFileName absolute-path baseline change. |
| testdata/baselines/reference/submoduleAccepted/conformance/jsxJsxsCjsTransformCustomImportPragma(jsx=react-jsxdev).js.diff | Accepts _jsxFileName absolute-path baseline change. |
| testdata/baselines/reference/submoduleAccepted/conformance/jsxJsxsCjsTransformKeyProp(jsx=react-jsxdev).js.diff | Accepts _jsxFileName absolute-path baseline change. |
| testdata/baselines/reference/submoduleAccepted/conformance/jsxJsxsCjsTransformKeyPropCustomImport(jsx=react-jsxdev).js.diff | Accepts _jsxFileName absolute-path baseline change. |
| testdata/baselines/reference/submoduleAccepted/conformance/jsxJsxsCjsTransformKeyPropCustomImportPragma(jsx=react-jsxdev).js.diff | Accepts _jsxFileName absolute-path baseline change. |
| testdata/baselines/reference/submoduleAccepted/conformance/jsxJsxsCjsTransformNestedSelfClosingChild(jsx=react-jsxdev).js.diff | Accepts _jsxFileName absolute-path baseline change. |
| testdata/baselines/reference/submoduleAccepted/conformance/jsxJsxsCjsTransformSubstitutesNames(jsx=react-jsxdev).js.diff | Accepts _jsxFileName absolute-path baseline change. |
| testdata/baselines/reference/submoduleAccepted/conformance/jsxJsxsCjsTransformSubstitutesNamesFragment(jsx=react-jsxdev).js.diff | Accepts _jsxFileName absolute-path baseline change. |
| testdata/baselines/reference/submoduleAccepted/conformance/tsxReactEmit8(jsx=react-jsxdev).js.diff | Accepts _jsxFileName absolute-path baseline change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old test harness didn't consistently use an absolute path, so these differ.
There's also:
Which is missing an indirect call, but this is actually erroring code, and what Strada did was wrong (note
_ais not declared!).