[http-server-js] handle Scalar and value literal return types in result processing#10058
Open
witemple-msft wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…result processing Adds a branch in `emitResultProcessingForType` to handle top-level `Scalar` and value literal (`String`, `Number`, `Boolean`) return types, using the existing JSON serialization helpers. Previously, any operation returning a bare scalar (e.g. `@get op read(): string;`) would crash with: Error: Unimplemented: result processing for type kind 'Scalar' Fixes microsoft#10005 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
witemple-msft
requested review from
AlitzelMendez,
bterlson,
chrisradek,
markcowl and
timotheeguerin
as code owners
commit: |
Contributor
|
❌ There is undocummented changes. Run The following packages have changes but are not documented.
Show changes |
Collaborator
|
You can try these changes here
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a branch in
emitResultProcessingForTypeto handle top-levelScalarand value literal (String,Number,Boolean) return types, using the existing JSON serialization helpers. Previously, any operation returning a bare scalar (e.g.@get op read(): string;) would crash with:Error: Unimplemented: result processing for type kind 'Scalar'
Fixes #10005