[http-server-js] handle Enum type in JSON serialization transpose helpers#10059
Open
witemple-msft wants to merge 1 commit intomicrosoft:mainfrom
Conversation
… helpers Adds `case "Enum": return expr;` to both `transposeExpressionToJson()` and `transposeExpressionFromJson()` in json.ts. Generated TS enums map to primitive (string/numeric) values that are directly JSON-compatible, so a no-op return is semantically correct. Fixes microsoft#9999 — crash when a model property has an Enum type and the enclosing model requires a JSON serializer (e.g. because a property name is a reserved keyword or has a wire-name rename). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
witemple-msft
requested review from
AlitzelMendez,
bterlson,
chrisradek,
markcowl and
timotheeguerin
as code owners
witemple-msft
changed the title
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
Collaborator
|
You can try these changes here
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
case "Enum": return expr;to bothtransposeExpressionToJson()andtransposeExpressionFromJson()in json.ts. Generated TS enums map to primitive (string/numeric) values that are directly JSON-compatible, so a no-op return is semantically correct.Fixes #9999 — crash when a model property has an Enum type and the enclosing model requires a JSON serializer (e.g. because a property name is a reserved keyword or has a wire-name rename).