Skip to content

[Python] Support patching polymorphic models #9923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
annatisch wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[Python] Support patching polymorphic models #9923

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/http-client-python/generator/pygen/codegen/templates/model_base.py.jinja2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,6 +725,10 @@ class Model(_MyMutableMapping):
def __init_subclass__(cls, discriminator: typing.Optional[str] = None) -> None:
for base in cls.__bases__:
if hasattr(base, "__mapping__"):
if discriminator is None:
# This could mean that a ploymorphic model has been patched without an explicit discriminator.
# We will attempt to find and replace its parent in the mapping.
discriminator = next((k for k, v in base.__mapping__.items() if v == base), None)
base.__mapping__[discriminator or cls.__name__] = cls # type: ignore

{% if code_model.has_padded_model_property %}
Expand Down
Loading