Fix super set for VSTHRD103

[Tobbeman]

Fixes bug raised here: #1422

The method of HasSupersetOfParameterTypes confused me as I think the check was inverted?
I took the liberty to change that as well, but let me know if I understand it wrong.

Any and all feedback is appreciated

[Tobbeman]

@Tobbeman please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

• (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

• (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

[Tobbeman]

On further thinking; would it not be better to be strict here, ensuring the method is a strict match or strict match + cancellationToken?

The current code will match, regardless of my change or not

void Bar(int i1) {}
Task BarAsync(int i1, int i2, int i3, int i4) => Task.CompletedTask

Only matching same arguments + optional cancellation token:

void Bar(int i1) {}
Task BarAsync(int i1, int i2, int i3, int i4) => Task.CompletedTask
Task BarAsync(int i1) => Task.CompletedTask // Match
Task BarAsync(int i1, CancellationToken t) => Task.CompletedTask // Match

[AArnott]

On further thinking; would it not be better to be strict here, ensuring the method is a strict match or strict match + cancellationToken?

It's a good question. But I am leaning toward encouraging users to switch to the async method and passing more arguments if necessary. If we get more feedback of concrete cases where that's not the right fix, then we can reevaluate.

[AArnott]

Thanks for reporting the bug and contributing the fix.

[AArnott]

I resolved conflicts with your PR, but despite GitHub saying I have permission to push back to your source branch, git is telling me that I don't. Would you like to resolve the conflicts and push an update to the PR so that we can merge this?