Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bobbrow
commented
Apr 3, 2026
| if (platform === 'win32') { | ||
| cp.spawn('cmd.exe', ['/c', 'start', 'cmd.exe', '/K', cmdLine], { cwd, env, detached: true, stdio: 'ignore' }).unref(); | ||
| } else if (platform === 'darwin') { | ||
| cp.spawn('osascript', ['-e', `tell application "Terminal" to do script "${this.escapeQuotes(cmdLine)}"`], { cwd, env, detached: true, stdio: 'ignore' }).unref(); |
Contributor
There was a problem hiding this comment.
@bobbrow I've tested this code path on mac (it worked).
Member
Author
There was a problem hiding this comment.
@sean-mcmanus cool! Does it work for paths with spaces and args with spaces too?
Contributor
There was a problem hiding this comment.
@bobbrow Yeah, it works with folders/files with spaces in the path, but what do you mean by "args with spaces"? i.e. I see the args be an array of strings. Do you mean like [ "one two", "three four" ]?
sean-mcmanus
reviewed
Apr 4, 2026
| "cwd": "$\{fileDirname\}", | ||
| "environment": [], | ||
| ${ type === "cppdbg" ? `"externalConsole": false` : `"console": "externalTerminal"` } | ||
| ${ type === "cppdbg" ? `"externalConsole": false` : `"console": "integratedTerminal"` } |
sean-mcmanus
reviewed
Apr 4, 2026
| Telemetry.logDebuggerEvent(DebuggerEvent.debugPanel, { "debugType": DebugType.debug, "configSource": folder ? ConfigSource.workspaceFolder : ConfigSource.singleFile, "configMode": ConfigMode.noLaunchConfig, "cancelled": "true", "succeeded": "true" }); | ||
| return undefined; // aborts debugging silently | ||
| } else { | ||
| const noDebug = config.noDebug ?? false; // preserve the noDebug value from the config if it exists. |
Contributor
There was a problem hiding this comment.
Comments ends with a period but doesn't start with a capital letter (versus the case on the next line).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1201
Supports both the Play button in the editor (run active file) and configurations specified in launch.json. macOS support needs to be tested - I don't currently have access to a machine.
Co-authored by GitHub Copilot