Fix LanguageClient.prepareRename() support for { defaultBehavior: true }#1748
Open
ndonfris wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix LanguageClient.prepareRename() support for { defaultBehavior: true }#1748ndonfris wants to merge 1 commit intomicrosoft:mainfrom
{ defaultBehavior: true }#1748ndonfris wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…ue }`
* /client behavior no longer converts `{ defaultBehavior: true }` to `null`, to now match >= 3.16.0 specification
- converts `{ defaultBehavior: true }` into the editor's default word range, allowing `textDocument/rename` requests without widening the VS Code provider type
- continues to reject `{ defaultBehavior: false }`, preventing `textDocument/rename` requests
* /client-node-tests new related `prepareRename` tests
- adds test server coverage for a controlled `{ defaultBehavior: true }` prepareRename response
- adds a dedicated integration test asserting the client converts that server result into a vscode.Range while keeping the existing Rename test focused on the standard flow
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/client behavior no longer converts
{ defaultBehavior: true }tonull, to now match >= 3.16.0 specification{ defaultBehavior: true }into the editor's default word range, allowingtextDocument/renamerequests without widening the VS Code provider type{ defaultBehavior: false }, preventingtextDocument/renamerequests/client-node-tests new related
prepareRenametests{ defaultBehavior: true }prepareRename response