Fix terminal commands incorrectly reporting exit code 130

[Copilot]

fixes #291871

Description

Agent-executed terminal commands reported exit code 130 (SIGINT) despite succeeding. Commands completed successfully (e.g., git commit created commits, echo $? showed 0), but agents received exit code 130.

Root causes:

1. Input tracking used wrong event: Listened to onData (all terminal data) instead of onDidInputData (input only), causing command output to set receivedUserInput = true

2. Listener timing issue: onCommandFinished listener was set up before SIGINT was sent. When SIGINT executed (triggered by false positive from Open Source VS Code #1), it fired onCommandFinished with exit 130, resolving the completion promise. Actual command then executed successfully, but exit code already captured as 130.

Changes:

• runInTerminalTool.ts: Changed input listener from onData to onDidInputData
• basicExecuteStrategy.ts: Moved onCommandFinished listener setup to after command execution

// Before: listener set up before command
const onDone = Promise.race([
  Event.toPromise(this._commandDetection.onCommandFinished, ...)
]);
await this._instance.sendText('\x03', false);  // SIGINT fires onCommandFinished → exit 130
this._instance.sendText(commandLine, true);    // Actual command succeeds but exit code already captured

// After: listener set up after command
await this._instance.sendText('\x03', false);
this._instance.sendText(commandLine, true);
const onDone = Promise.race([
  Event.toPromise(this._commandDetection.onCommandFinished, ...)  // Now captures actual command
]);

Original prompt

Terminal runs especially within thinking block by an agent are being interpreted as the command exits with code 130 despite double checking within the terminal by running echo $? I see exit code 0 -- I also see the effect of the command run, e.g., if git commit was run then the commit does exist, but agent thinks it exited with 130.

The user has attached the following file paths as relevant context:

• .github/copilot-instructions.md
• AGENTS.md

Created from VS Code.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.