Include ID in reporter for telemetry tracking #291890
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the telemetry tracking infrastructure for action widget dropdowns by introducing a required id field to the reporter object while making the name field optional. This change enables unique identification of each dropdown action in telemetry logs through a stable identifier.
Changes:
- Modified the
IActionWidgetDropdownOptionsinterface to require anidfield and makenameoptional in the reporter object - Updated the telemetry event types and classification to include the new
idfield - Updated all call sites across chat-related components to provide both
idandnamefields in their reporter configurations
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/actionWidget/browser/actionWidgetDropdown.ts | Modified the reporter interface to require id and make name optional; updated telemetry event types and classifications |
| src/vs/workbench/contrib/chat/browser/widget/input/workspacePickerActionItem.ts | Added id field to reporter configuration for ChatWorkspacePicker |
| src/vs/workbench/contrib/chat/browser/widget/input/sessionTargetPickerActionItem.ts | Added id field to reporter configuration for ChatSessionTypePicker |
| src/vs/workbench/contrib/chat/browser/widget/input/modelPickerActionItem.ts | Added id field to reporter configuration for ChatModelPicker |
| src/vs/workbench/contrib/chat/browser/widget/input/modePickerActionItem.ts | Added id field to reporter configuration for ChatModePicker |
| src/vs/workbench/contrib/chat/browser/chatSessions/chatSessionPickerActionItem.ts | Added dynamic id field using group.id for ChatSession reporter |
| src/vs/workbench/contrib/chat/browser/actions/chatContinueInAction.ts | Added id field to reporter configuration for ChatContinueInSession |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
alexr00
approved these changes
Jan 30, 2026
Member
|
@benibenj red CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copilot Generated Description:Update the reporter object in various action items to include an ID for improved telemetry tracking. This change ensures that each action can be uniquely identified in telemetry logs.