Skip to content

[WIP] Fix url.parse deprecation warning on Node 24#302483

Draft
Copilot wants to merge 1 commit intomainfrom
copilot/fix-url-parse-deprecation-warning
Draft

[WIP] Fix url.parse deprecation warning on Node 24#302483
Copilot wants to merge 1 commit intomainfrom
copilot/fix-url-parse-deprecation-warning

Conversation

Copy link
Contributor

Copilot AI commented Mar 17, 2026

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.


This section details on the original issue you should resolve

<issue_title>Cause url.parse deprecation warning on Node 24</issue_title>
<issue_description>

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: Built from main branch.
  • OS Version: Debian 13.
(node:390621) [DEP0169] DeprecationWarning: `url.parse()` behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued for `url.parse()` vulnerabilities.
    at urlParse (node:url:136:13)
    at P_ (file:///media/kkocdko/KK_TMP_1/vscode/out/server-main.js:46:11939)
    at rl.request (file:///media/kkocdko/KK_TMP_1/vscode/out/server-main.js:46:14798)
    at process.processTicksAndRejections (node:internal/process/task_queues:103:5)
    at async fB (file:///media/kkocdko/KK_TMP_1/vscode/out/server-main.js:184:103731)
    at async pB (file:///media/kkocdko/KK_TMP_1/vscode/out/server-main.js:184:104460)

Maybe we can replace it to URL.parse static function? I'm reading the code about every url.parse call. Wait for me.

Code search result
</issue_description>

Comments on the Issue (you are @copilot in this section)

@bpasero Usages in: * `src/vs/platform/request/node/requestService.ts` * `src/vs/platform/request/node/proxy.ts` * `src/vs/server/node/server.cli.ts`

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants