fix: Restrict Emmet commands to Emmet-supported languages only#302487
Draft
fix: Restrict Emmet commands to Emmet-supported languages only#302487
Conversation
Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix emmet action toggle comment bug
fix: Restrict Emmet commands to Emmet-supported languages only
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emmet commands (e.g.
editor.emmet.action.toggleComment) were executing on arbitrary file types like Java, applying HTML/CSS comment syntax where it doesn't belong.Changes
extensions/emmet/src/util.ts—validate(): Added an Emmet language check using the existinggetEmmetMode()infrastructure. Commands now bail out early for unsupported languages.Since all Emmet actions call
validate()at entry, this single change gates all commands.emmet.includeLanguagesandemmet.excludeLanguagesuser settings are respected.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.