Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds performance marks across the chat submit/request pipeline to enable end-to-end timing analysis from UI submission through agent invocation in the workbench chat feature.
Changes:
- Add perf markers when entering
ChatService.sendRequestand_sendRequestAsync. - Add perf markers around agent invocation (
invokeAgent) to measure provider execution time. - Add perf markers at key UI submission points (
acceptInput, widget send, submit action).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/chatService/chatServiceImpl.ts | Adds chat request lifecycle and agent-invocation performance marks in the core chat service. |
| src/vs/workbench/contrib/chat/browser/widget/chatWidget.ts | Adds UI-side marks for accept-input and just-before calling chatService.sendRequest. |
| src/vs/workbench/contrib/chat/browser/actions/chatExecuteActions.ts | Adds a mark when running the submit action. |
You can also share your feedback on Copilot code review. Take the survey.
roblourens
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample trace for a single (already authenticated) chat request
TODO: add related marks in copilot extension