Fix CLI handling of --folder-uri when used with other flags like --wait#302519
Open
omwanere wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix CLI handling of --folder-uri when used with other flags like --wait#302519omwanere wants to merge 1 commit intomicrosoft:mainfrom
omwanere wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalize URI values passed through --folder-uri before resolving them.
This prevents Electron argument parsing issues where URI schemes containing
':' can interfere with argument ordering when combined with flags such as --wait.
Tested with:
--folder-uri --wait
--wait --folder-uri
Both now open correctly.