Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a hang/infinite recursion scenario in the extension host language model selection flow when the main thread returns model identifiers that are missing from the extension host’s local model cache (notably in Remote-SSH scenarios, per #302532).
Changes:
- Add a
resolveIfMissingparameter togetLanguageModelByIdentifierto control whether it should trigger a re-resolve viaselectLanguageModels. - Prevent re-entrant resolution loops by disabling “resolve-if-missing” when
selectLanguageModelsis already in progress. - Improve logging for the “model missing from local cache” case without re-triggering model selection.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #302532
confirmed the fix with https://builds.code.visualstudio.com/builds/insider?commit=663b88e0e69b5172cd7b165da010f6c768f9cdd4&dev=true