Minor YamlCreate bug Fixes#326440
Merged
denelon merged 3 commits intomicrosoft:masterfrom Dec 26, 2025
Merged
Conversation
microsoft-github-policy-service
bot
added
the
Needs-Attention
Trenly
changed the title
microsoft-github-policy-service
bot
removed
the
Needs-Attention
denelon
approved these changes
Dec 26, 2025
microsoft-github-policy-service
bot
added
the
Moderator-Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist for Pull Requests
There's a small issue where with MSI files, the module responsible for fetching the MSI properties doesn't always release the file handle right away. Since the module is in the process of releasing the file handle, and there isn't great visibility into whether or not the file handle has been released, it makes the most sense just to retry the deletion.
This PR also fixes an issue where the ProductCode detection was broken after updating to use the PowerShell module
cc @denelon @mdanish-kh
Microsoft Reviewers: Open in CodeFlow