Skip to content

Fix output of CheckDisplayVersions.ps1#327815

Merged
denelon merged 3 commits intomicrosoft:masterfrom
KarbitsCode:fix-check-display-version-script
Jan 26, 2026
Merged

Fix output of CheckDisplayVersions.ps1#327815
denelon merged 3 commits intomicrosoft:masterfrom
KarbitsCode:fix-check-display-version-script

Conversation

@KarbitsCode
Copy link
Copy Markdown
Contributor

@KarbitsCode KarbitsCode commented Jan 5, 2026

I was just try to use some of the scripts in the Tools folder, I found out that CheckDisplayVersions.ps1 weirdly didn't output anything:
Screenshot 2026-01-05 082606

Despite there is a value in that variable visible only on Write-Host:
Screenshot 2026-01-05 084706

So, I add Format-Table to output as table like it supposed to be:
Screenshot 2026-01-05 091506

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.10 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@KarbitsCode KarbitsCode marked this pull request as ready for review January 5, 2026 01:42
@KarbitsCode KarbitsCode requested a review from denelon as a code owner January 5, 2026 01:42
Copilot AI review requested due to automatic review settings January 5, 2026 01:42
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 5, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes output formatting issues in the CheckDisplayVersions.ps1 PowerShell script to properly display results in a table format.

  • Updates verbose message terminology from "monikers" to "DisplayVersions" for clarity
  • Adds Format-Table -Wrap to format the output as a table when DisplayVersion conflicts are found

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Tools/CheckDisplayVersions.ps1 Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 5, 2026
@denelon
Copy link
Copy Markdown
Collaborator

denelon commented Jan 5, 2026

@Trenly are you good with this, or did you want to make some other improvements?

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 5, 2026
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 20, 2026
@KarbitsCode
Copy link
Copy Markdown
Contributor Author

cc @Trenly @denelon

@KarbitsCode KarbitsCode requested a review from Trenly January 21, 2026 03:30
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 26, 2026
@denelon denelon merged commit d4e418d into microsoft:master Jan 26, 2026
1 check passed
@KarbitsCode KarbitsCode deleted the fix-check-display-version-script branch January 27, 2026 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Moderator-Approved One of the Moderators has reviewed and approved this PR Project-File

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants