Skip to content

feat: add overenskomst preset selector to Pay Rule Set create modal #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renemadsen merged 21 commits into from
Apr 9, 2026
Merged

feat: add overenskomst preset selector to Pay Rule Set create modal #1465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
1eb7a08
Add design spec for Pay Rule Set preset selector
renemadsen Apr 8, 2026
a5d261b
feat: add overenskomst preset selector to Pay Rule Set create modal
renemadsen Apr 8, 2026
4d82996
fix: add PayRuleSetsService mock to assigned-site-dialog unit tests
renemadsen Apr 8, 2026
7c865f1
fix: rewrite GLS-A/3F pay rules E2E test with correct selectors from …
renemadsen Apr 8, 2026
5edc09c
fix: add missing PayRuleSetsService mock in second TestBed + fix time…
renemadsen Apr 8, 2026
2a112ae
fix: use proven patterns from existing tests for E2E reliability
renemadsen Apr 8, 2026
d7037c9
fix: navigate to Pay Rule Sets via direct URL (no sidebar menu item)
renemadsen Apr 8, 2026
71316ce
fix: set shift times in correct order (start -> stop -> break)
renemadsen Apr 8, 2026
900a072
fix: use AM hours (1-12) for planned shift timepicker clock face
renemadsen Apr 8, 2026
95f802c
fix: correct parameter order (start,stop,pause) and avoid hour 0 in b…
renemadsen Apr 8, 2026
cefbf5a
fix: remove timepicker shift entry from Scenario 1
renemadsen Apr 8, 2026
912ae93
Add design spec for expanded overenskomst presets (GLS-A + KA/Krifa)
renemadsen Apr 9, 2026
40e28e5
Add implementation plan for expanded overenskomst presets
renemadsen Apr 9, 2026
e97631c
Add Playwright E2E tests for KA/Krifa and GLS-A Gartneri presets
renemadsen Apr 9, 2026
aef674d
feat: add 14 new overenskomst presets (GLS-A Gartneri/Skovbrug + KA/K…
renemadsen Apr 9, 2026
ed6765a
fix: update spec to reflect locked presets are not deletable
renemadsen Apr 9, 2026
a8b443d
fix: address Copilot review - spread sort, inline style, spec doc
renemadsen Apr 9, 2026
22d33e6
fix: address Copilot review - singleton fetch + backend delete guard
renemadsen Apr 9, 2026
e5cb2f3
feat: always record Playwright video + upload artifacts on success
renemadsen Apr 9, 2026
56623bc
Update E2E test assertions to include overenskomst validity periods
renemadsen Apr 9, 2026
8cf195d
feat: add validity period to all overenskomst preset names
renemadsen Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/dotnet-core-master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ jobs:
if: ${{ failure() }}
run: cat docker_run_log
- name: Archive Playwright report
if: failure()
if: always()
uses: actions/upload-artifact@v4
with:
name: playwright-report-${{ matrix.test }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dotnet-core-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ jobs:
if: ${{ failure() }}
run: cat docker_run_log
- name: Archive Playwright report
if: failure()
if: always()
uses: actions/upload-artifact@v4
with:
name: playwright-report-${{ matrix.test }}
Expand Down
Loading
Loading