Fix: API DELETE container skips Proxmox deletion#268
Closed
Conversation
Agent-Logs-Url: https://github.com/mieweb/opensource-server/sessions/0f37bcbb-69a5-482f-a2f3-831a012a8b4c Co-authored-by: runleveldev <44057501+runleveldev@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix API to delete Proxmox container correctly
Fix: API DELETE container skips Proxmox deletion
Mar 31, 2026
runleveldev
requested changes
Mar 31, 2026
Collaborator
runleveldev
left a comment
There was a problem hiding this comment.
@copilot this is repetitive with code elsewhere in the router. Minimize repetition rather than minimizing changes.
…dler branches Agent-Logs-Url: https://github.com/mieweb/opensource-server/sessions/8dc9aa4d-8e25-4825-9a0b-feccd0a524a6 Co-authored-by: runleveldev <44057501+runleveldev@users.noreply.github.com>
Contributor
Author
Refactored in d080fc0. Extracted a |
Collaborator
|
Implemented in #269 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deleting a container via the JSON API, only the database record was removed — the Proxmox LXC container was left alive. The
isApiRequestbranch bypassed all Proxmox cleanup logic that existed in the browser form path.Changes
Nodeassociation in the API path's container query so the Proxmox API client can be constructedapi.deleteContainer()withforce=true, purge=truebefore DB destroyapi.lxcConfig()— returns409JSON on mismatch instead of silently skipping or redirecting