Skip to content

feat(condensed): add condensed view support for Messaging and Toast components#156

Merged
garrity-miepub merged 4 commits intomainfrom
feature/condensed-view-messaging
Apr 1, 2026
Merged

feat(condensed): add condensed view support for Messaging and Toast components#156
garrity-miepub merged 4 commits intomainfrom
feature/condensed-view-messaging

Conversation

@garrity-miepub
Copy link
Copy Markdown
Contributor

@garrity-miepub garrity-miepub commented Apr 1, 2026

Condensed view support for Messaging and Toast components

Messaging

  • Add 31 data-slot attributes across 7 files: MessageThread (5), ConversationHeader (7), MessageList (7), MessageBubble (8), MessageComposer (6), AttachmentPicker (1)
  • Add ~315 lines of condensed CSS covering: conversation header, conversation list items, message list, date separators, typing indicator, empty state, load more, message bubbles, composer with aligned input/buttons/char count
  • Fix composer vertical alignment: flex centering, textarea height override, character counter repositioning

Toast

  • Add 8 data-slot attributes: toast, toast-icon, toast-content, toast-title, toast-message, toast-action, toast-dismiss, toast-container
  • Add condensed CSS for compact padding, smaller icons, reduced font sizes, narrower min/max widths

Review fixes

  • Replace fragile structural selectors (:first-child, :last-child, .relative, #char-count) with dedicated data-slots
  • Use > span direct child selector for reaction pills to avoid matching nested spans
  • Exclude badge data-slot from conversation list item span selector to prevent specificity conflicts

- Add 31 data-slot attributes across 7 files:
  MessageThread (5), ConversationHeader (7), MessageList (7),
  MessageBubble (8), MessageComposer (6), AttachmentPicker (1)
- Add ~315 lines of condensed CSS covering:
  conversation header, conversation list items, message list,
  date separators, typing indicator, empty state, load more,
  message bubbles, composer with aligned input/buttons/char count
- Fix composer vertical alignment: flex centering, textarea
  height override, character counter repositioning
Copilot AI review requested due to automatic review settings April 1, 2026 01:24
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Apr 1, 2026

Deploying ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: 703b128
Status: ✅  Deploy successful!
Preview URL: https://e9913ab1.ui-6d0.pages.dev
Branch Preview URL: https://feature-condensed-view-messa.ui-6d0.pages.dev

View logs

@garrity-miepub garrity-miepub marked this pull request as ready for review April 1, 2026 01:25
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds condensed-density styling support for the Messaging UI by introducing data-slot hooks in Messaging components and new condensed overrides in condensed-view.css, aligning Messaging with the repo’s existing condensed-mode pattern.

Changes:

  • Added data-slot attributes across Messaging components (thread, header/list items, message list/bubbles, composer, attachment picker, lightbox) to provide stable styling hooks.
  • Added a new “Messaging – condensed overrides” section to src/styles/condensed-view.css covering header, conversation list items, message list states, bubbles, and composer layout/alignment.
  • Adjusted condensed composer layout (centering/alignment + textarea/character counter positioning).

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/styles/condensed-view.css Adds condensed-mode CSS overrides targeting new Messaging data-slot hooks.
src/components/Messaging/MessageThread.tsx Adds data-slot hooks to thread containers and lightbox/split-view wrappers.
src/components/Messaging/MessageList.tsx Adds data-slot hooks for list container/content and message list states (typing, empty, load more, skeleton).
src/components/Messaging/MessageComposer.tsx Adds data-slot hooks for composer form areas (reply preview, attachments, input area/input, send button).
src/components/Messaging/MessageBubble.tsx Adds data-slot hooks to bubble elements (system, avatar, sender name, reply preview, content, footer, reactions).
src/components/Messaging/ConversationHeader.tsx Adds data-slot hooks for conversation header and conversation list item sub-elements.
src/components/Messaging/AttachmentPicker.tsx Adds data-slot hook for the attachment picker button for condensed styling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Address Copilot review comments on PR #156:
- Reaction pills: use > span direct child selector
- Skeleton messages: add skeleton-avatar/bubble/spacer data-slots
- Empty state: add message-empty-state-icon data-slot
- Composer: add composer-input-wrapper and composer-char-count data-slots
Copilot AI review requested due to automatic review settings April 1, 2026 01:34
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@garrity-miepub garrity-miepub changed the title feat(condensed): add condensed view support for Messaging components feat(condensed): add condensed view support for Messaging and Toast components Apr 1, 2026
@garrity-miepub garrity-miepub merged commit 6568ec5 into main Apr 1, 2026
10 checks passed
@garrity-miepub garrity-miepub deleted the feature/condensed-view-messaging branch April 1, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants