UPSTREAM: <carry>: Disable irrelevant CI workflows

[mpryc]

Summary

• Disable 16 irrelevant upstream kopia GitHub Actions workflows (renamed to .yml.disabled)
• Update lint.yml and tests.yml: branch filters (master → oadp-dev/oadp-1.*), OS matrix (ubuntu-only), remove Windows/macOS steps, remove integration tests and scheduled runs

Structured as 2 clean commits for easy cherry-pick to oadp-1.6 (and oadp-vmdp).

Signed-off-by: Michal Pryc mpryc@redhat.com

🤖 Generated with Claude Code

Summary by CodeRabbit

• Chores
  • CI workflows now target oadp-dev and oadp-1.* branches.
  • Simplified lint/test runs to Ubuntu only; removed macOS/Windows runners.
  • Removed scheduled cron and the automated integration-test step from CI.
  • Removed the vulnerability scanning (govulncheck) step from CI.
  • Minor Azure backend code cleanup with no functional or behavioral changes.

[oadp-snyk]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[coderabbitai]

📝 Walkthrough

Walkthrough

CI workflows narrowed to oadp-dev and oadp-1.* branches and consolidated to ubuntu-latest; scheduled cron and several test/vulncheck steps removed. Minor Go setup change and Azure blob callback parameter adjusted; small import and doc-comment punctuation tweak in Azure patch.

Changes

Cohort / File(s)	Summary
Workflow: lint ​.github/workflows/lint.yml	Narrowed pull_request branch filters to oadp-dev, oadp-1.*; reduced job matrix to ubuntu-latest; removed govulncheck step and its Go action configuration; removed make check-locks/make check-prettier, leaving make lint.
Workflow: tests ​.github/workflows/tests.yml	Retargeted pull_request/push events to oadp-dev, oadp-1.*; removed scheduled cron and prior push branches; simplified runners to ubuntu-latest only; removed Windows/macOS setup; replaced make -j4 ci-setup with make -j4 go-modules all-tools; removed standalone integration test step, adjusted test steps and artifact upload.
Azure blob patch repo/blob/azure/patch.go	Added/normalized github.com/pkg/errors import placement; updated NewWithClient doc comment punctuation; changed raw.ListBlobs(...) callback param to _ blob.Metadata to ignore metadata while preserving behavior and error wrapping.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

lgtm

Poem

🐰 I hopped through CI gardens, trimmed branches with care,
One runner now naps where many once were there.
A vuln-check waved goodbye, Azure meta tucked neatly,
I hide tiny changes and nibble them sweetly.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: disabling irrelevant CI workflows for the downstream fork. It is specific, clear, and directly related to the changeset.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (2)

.github/workflows/tests.yml (1)

18-18: Same as lint.yml: UNIX_SHELL_ON_WINDOWS is now dead configuration.

Consider removing this env var since Windows is no longer in the matrix.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/tests.yml at line 18, Remove the obsolete environment
variable UNIX_SHELL_ON_WINDOWS from the tests workflow: locate the env block in
the .github/workflows/tests.yml where UNIX_SHELL_ON_WINDOWS: true is declared
and delete that entry (or the sole line) since Windows runners are no longer in
the matrix; ensure the rest of the env block and YAML indentation remain valid
after removal.

.github/workflows/lint.yml (1)

14-14: Consider removing UNIX_SHELL_ON_WINDOWS since Windows is no longer in the matrix.

With the OS matrix reduced to ubuntu-latest only, the UNIX_SHELL_ON_WINDOWS: true environment variable is now unused. This is harmless but could be cleaned up to avoid confusion.

🧹 Optional cleanup

 env:
   # environment variables shared between build steps
   # do not include sensitive credentials and tokens here, instead pass them
   # directly to tools that need them to limit the blast radius in case one of them
   # becomes compromised and leaks credentials to external sites.
-  # required by Makefile
-  UNIX_SHELL_ON_WINDOWS: true
   # set (to any value other than false) to trigger random unicode filenames testing (logs may be difficult to read)

Also applies to: 24-24

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/lint.yml at line 14, Remove the now-unused
UNIX_SHELL_ON_WINDOWS environment variable from the GitHub Actions lint
workflow: locate the env entry named UNIX_SHELL_ON_WINDOWS in the lint
workflow's environment block and delete that key (and any duplicate occurrence
noted around the second mention) so the workflow no longer exposes an unused
Windows-specific flag; ensure the workflow remains valid YAML after removal.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/workflows/lint.yml:
- Line 14: Remove the now-unused UNIX_SHELL_ON_WINDOWS environment variable from
the GitHub Actions lint workflow: locate the env entry named
UNIX_SHELL_ON_WINDOWS in the lint workflow's environment block and delete that
key (and any duplicate occurrence noted around the second mention) so the
workflow no longer exposes an unused Windows-specific flag; ensure the workflow
remains valid YAML after removal.

In @.github/workflows/tests.yml:
- Line 18: Remove the obsolete environment variable UNIX_SHELL_ON_WINDOWS from
the tests workflow: locate the env block in the .github/workflows/tests.yml
where UNIX_SHELL_ON_WINDOWS: true is declared and delete that entry (or the sole
line) since Windows runners are no longer in the matrix; ensure the rest of the
env block and YAML indentation remain valid after removal.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 11332781-e010-474f-afee-d369f8c0c309

📥 Commits

Reviewing files that changed from the base of the PR and between 7e7ed77 and 179fe88.

📒 Files selected for processing (18)

• .github/workflows/auto-merge.yml.disabled
• .github/workflows/check-pr-title.yml.disabled
• .github/workflows/code-coverage.yml.disabled
• .github/workflows/compat-test.yml.disabled
• .github/workflows/dependency-review.yml.disabled
• .github/workflows/endurance-test.yml.disabled
• .github/workflows/htmlui-tests.yml.disabled
• .github/workflows/license-check.yml.disabled
• .github/workflows/lint.yml
• .github/workflows/make.yml.disabled
• .github/workflows/ossf-scorecard.yml.disabled
• .github/workflows/providers-core.yml.disabled
• .github/workflows/providers-extra.yml.disabled
• .github/workflows/race-detector.yml.disabled
• .github/workflows/stale.yml.disabled
• .github/workflows/stress-test.yml.disabled
• .github/workflows/tests.yml
• .github/workflows/volume-shadow-copy-test.yml.disabled

[mpryc]

/hold

[mpryc]

/unhold

[coderabbitai]

🧹 Nitpick comments (1)

.github/workflows/tests.yml (1)

42-45: Integration tests removed from CI pipeline.

The workflow now only runs test-index-blob-v0 and ci-tests (unit tests). The ci-integration-tests step (which runs robustness-tool-tests and socket-activation-tests) has been removed entirely.

This eliminates integration test coverage from CI. If this is intentional for the downstream fork, consider documenting where/how integration tests are validated (e.g., separate pipeline, manual testing, or upstream reliance).

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/tests.yml around lines 42 - 45, The CI workflow removed
the integration test job "ci-integration-tests" (which ran steps
"robustness-tool-tests" and "socket-activation-tests"), removing integration
coverage; to fix either restore the missing job or explicitly document the new
integration test strategy: re-add a job named "ci-integration-tests" with steps
that run "robustness-tool-tests" and "socket-activation-tests" (or call the
existing target that runs both) and wire its needs/permissions/runner matching
the original pipeline, or add a clear comment in the workflow header and
repository README describing where/how integration tests are executed (e.g.,
separate pipeline name, manual run instructions, or relying on upstream CI).

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/workflows/tests.yml:
- Around line 42-45: The CI workflow removed the integration test job
"ci-integration-tests" (which ran steps "robustness-tool-tests" and
"socket-activation-tests"), removing integration coverage; to fix either restore
the missing job or explicitly document the new integration test strategy: re-add
a job named "ci-integration-tests" with steps that run "robustness-tool-tests"
and "socket-activation-tests" (or call the existing target that runs both) and
wire its needs/permissions/runner matching the original pipeline, or add a clear
comment in the workflow header and repository README describing where/how
integration tests are executed (e.g., separate pipeline name, manual run
instructions, or relying on upstream CI).

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 444b1b2c-e493-481c-ad0a-9606a7a9cd94

📥 Commits

Reviewing files that changed from the base of the PR and between 3d57d7c and 8a94073.

📒 Files selected for processing (3)

• .github/workflows/lint.yml
• .github/workflows/tests.yml
• repo/blob/azure/patch.go

✅ Files skipped from review due to trivial changes (1)

• repo/blob/azure/patch.go

🚧 Files skipped from review as they are similar to previous changes (1)

• .github/workflows/lint.yml

[kaovilai]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mpryc, shubham-pampattiwar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kaovilai,mpryc,shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment