Skip to content

[oadp-1.6] Prepare oadp-cli for Konflux onboarding into OADP 1.6#172

Merged
mpryc merged 2 commits intomigtools:oadp-1.6from
openshift-cherrypick-robot:cherry-pick-169-to-oadp-1.6
Mar 30, 2026
Merged

[oadp-1.6] Prepare oadp-cli for Konflux onboarding into OADP 1.6#172
mpryc merged 2 commits intomigtools:oadp-1.6from
openshift-cherrypick-robot:cherry-pick-169-to-oadp-1.6

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #169

/assign mpryc

Rename konflux.Containerfile.download to konflux.Dockerfile to match
ocp-build-data expectations. Move FIPS flags (GOEXPERIMENT, strictfipsruntime)
from global ENV to only the download-server build — CLI archives need
CGO_ENABLED=0 for cross-platform portability. Change -mod=mod to
-mod=readonly for hermetic Konflux builds.

Signed-off-by: Joseph <jvaikath@redhat.com>
Documents the end-to-end process for adding a new image component to
the OADP Konflux build pipeline: openshift-priv mirror setup, Dockerfile
pattern, pyxis-repo-configs, RPAs, and ocp-build-data configuration.

Signed-off-by: Joseph <jvaikath@redhat.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3fe46038-c69f-4911-b90c-233a82315318

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mpryc
Copy link
Copy Markdown
Contributor

mpryc commented Mar 30, 2026

/lgtm

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mpryc, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mpryc mpryc merged commit 845e083 into migtools:oadp-1.6 Mar 30, 2026
8 checks passed
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 30, 2026

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 0b7bde0 link unknown /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants