Set GOTOOLCHAIN=go1.25.7 in konflux.Dockerfile#176
Set GOTOOLCHAIN=go1.25.7 in konflux.Dockerfile#176kaovilai wants to merge 1 commit intomigtools:oadp-1.6from
Conversation
Override the go.mod toolchain go1.25.8 directive to use go1.25.7 during Konflux builds, as go1.25.8 is not yet available in the builder image. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
Pins the Go toolchain used by the Konflux hermetic build to unblock builds when the toolchain go1.25.8 directive from go.mod cannot be satisfied by the current builder image.
Changes:
- Add
ENV GOTOOLCHAIN=go1.25.7to the Konflux builder stage to override Go’s toolchain selection.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # into the build context before this Dockerfile runs. | ||
|
|
||
| FROM brew.registry.redhat.io/rh-osbs/openshift-golang-builder:rhel_9_golang_1.25 AS builder | ||
| ENV GOTOOLCHAIN=go1.25.7 |
There was a problem hiding this comment.
Setting GOTOOLCHAIN=go1.25.7 in a hermetic Konflux build can become brittle: if/when the builder image is updated to ship a different patch (e.g. go1.25.8), go may try to switch to/go-download 1.25.7 (which likely fails in a hermetic environment). Consider using GOTOOLCHAIN=local to force using the toolchain already present in the image (still bypassing the toolchain go1.25.8 directive), or add an explicit note/TODO describing when/how this pin should be removed/updated alongside the builder image tag.
| ENV GOTOOLCHAIN=go1.25.7 | |
| ENV GOTOOLCHAIN=local |
|
Closing in favor of openshift-eng/ocp-build-data#9788 which negates the need for this change. |
Summary
toolchain go1.25.8from go.mod withGOTOOLCHAIN=go1.25.7in the Konflux builder stageTest plan