Skip to content

Set GOTOOLCHAIN=go1.25.7 in konflux.Dockerfile#176

Closed
kaovilai wants to merge 1 commit intomigtools:oadp-1.6from
kaovilai:oadp-1.6-gotoolchain
Closed

Set GOTOOLCHAIN=go1.25.7 in konflux.Dockerfile#176
kaovilai wants to merge 1 commit intomigtools:oadp-1.6from
kaovilai:oadp-1.6-gotoolchain

Conversation

@kaovilai
Copy link
Copy Markdown
Member

@kaovilai kaovilai commented Apr 2, 2026

Summary

  • Override toolchain go1.25.8 from go.mod with GOTOOLCHAIN=go1.25.7 in the Konflux builder stage
  • go1.25.8 is not yet available in the builder image; this pins to go1.25.7 to unblock builds

Test plan

  • Konflux build succeeds with go1.25.7

Override the go.mod toolchain go1.25.8 directive to use go1.25.7
during Konflux builds, as go1.25.8 is not yet available in the
builder image.

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>
Copilot AI review requested due to automatic review settings April 2, 2026 15:30
@openshift-ci openshift-ci bot requested review from Joeavaikath and sseago April 2, 2026 15:30
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 2, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dfe21240-66c3-4c98-9b1f-773a432f0570

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the Go toolchain used by the Konflux hermetic build to unblock builds when the toolchain go1.25.8 directive from go.mod cannot be satisfied by the current builder image.

Changes:

  • Add ENV GOTOOLCHAIN=go1.25.7 to the Konflux builder stage to override Go’s toolchain selection.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

# into the build context before this Dockerfile runs.

FROM brew.registry.redhat.io/rh-osbs/openshift-golang-builder:rhel_9_golang_1.25 AS builder
ENV GOTOOLCHAIN=go1.25.7
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting GOTOOLCHAIN=go1.25.7 in a hermetic Konflux build can become brittle: if/when the builder image is updated to ship a different patch (e.g. go1.25.8), go may try to switch to/go-download 1.25.7 (which likely fails in a hermetic environment). Consider using GOTOOLCHAIN=local to force using the toolchain already present in the image (still bypassing the toolchain go1.25.8 directive), or add an explicit note/TODO describing when/how this pin should be removed/updated alongside the builder image tag.

Suggested change
ENV GOTOOLCHAIN=go1.25.7
ENV GOTOOLCHAIN=local

Copilot uses AI. Check for mistakes.
@kaovilai
Copy link
Copy Markdown
Member Author

kaovilai commented Apr 2, 2026

Closing in favor of openshift-eng/ocp-build-data#9788 which negates the need for this change.

@kaovilai kaovilai closed this Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants