Fix the click handling for checkboxes inside labels; Move click handling into render function#92
Open
aAXEe wants to merge 1 commit intominhur:masterfrom
Open
Fix the click handling for checkboxes inside labels; Move click handling into render function#92aAXEe wants to merge 1 commit intominhur:masterfrom
aAXEe wants to merge 1 commit intominhur:masterfrom
Conversation
…ing into render function
|
Works fine for me, why no merge yet? |
|
Sad that this hasnt ever been merged, as it fixes the issue. Had to add the changes to a locally cached copy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #75 and fixes #23.
From my point of view adding the click handlers inside the
renderfunction is better than in thedefaultsfunction (as suggested in #75). Additionally the code from #75 does not work for all cases.Have a look at http://aaxee.github.io/bootstrap-toggle/ for a preview.
A toggle is triggered by clicking on the label or by clicking on the toggle-element.