Skip to content

enhance(frontend): PWA WindowControlsOverlayに対応#17291

Draft
kakkokari-gtyih wants to merge 2 commits intomisskey-dev:developfrom
kakkokari-gtyih:enh-pwa-titlebar
Draft

enhance(frontend): PWA WindowControlsOverlayに対応#17291
kakkokari-gtyih wants to merge 2 commits intomisskey-dev:developfrom
kakkokari-gtyih:enh-pwa-titlebar

Conversation

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor

What

image
  • WindowControlsOverlayに対応している環境では強制的にタイトルバーが表示され、ウィンドウのタイトルバーとして用いられるように
  • タイトルバーの幅がenvの値を反映するように
  • HTML theme-colorが、WindowControlsOverlayの実行中はタイトルバーの色になるように

Why

experimental

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR labels Apr 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Backend memory usage comparison

Before GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 321.88 MB 318.85 MB -3.02 MB -0.93%
VmHWM 321.88 MB 318.85 MB -3.02 MB -0.93%
VmSize 23115.18 MB 23110.85 MB -4.33 MB -0.01%
VmData 1385.78 MB 1382.01 MB -3.77 MB -0.27%

After GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 321.88 MB 318.87 MB -3.01 MB -0.93%
VmHWM 321.88 MB 318.87 MB -3.01 MB -0.93%
VmSize 23115.18 MB 23110.85 MB -4.33 MB -0.01%
VmData 1385.78 MB 1382.01 MB -3.77 MB -0.27%

After Request

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 322.29 MB 319.18 MB -3.11 MB -0.96%
VmHWM 322.29 MB 319.18 MB -3.11 MB -0.96%
VmSize 23115.26 MB 23110.85 MB -4.41 MB -0.01%
VmData 1385.87 MB 1382.01 MB -3.85 MB -0.27%

See workflow logs for details

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.66%. Comparing base (92e0e8e) to head (bf9fc21).

Files with missing lines Patch % Lines
packages/frontend/src/utility/popup-position.ts 0.00% 1 Missing and 3 partials ⚠️
...ages/backend/src/server/web/ClientServerService.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17291      +/-   ##
===========================================
- Coverage    63.79%   63.66%   -0.13%     
===========================================
  Files         1162     1162              
  Lines       116401   116407       +6     
  Branches      8455     8416      -39     
===========================================
- Hits         74261    74115     -146     
- Misses       39941    40111     +170     
+ Partials      2199     2181      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR

Projects

Development

Successfully merging this pull request may close these issues.

1 participant