Created a buffer API definition in buffer/api.h to allow access to FX2 buffers using a standard manner#25
Open
RacingTornado wants to merge 1 commit intomithro:linux-descriptorsfrom
Conversation
Owner
|
Saying "there seems to be a problem" is not useful. Describe the expected (what you think should happen) and actual behaviour (what you observe happening). |
| BYTE bufferX_flush(); | ||
|
|
||
| /** | ||
| * \brief Returns the maximum size of the buffer. WARNING:(This is always less than 256 bytes). |
Owner
There was a problem hiding this comment.
This doesn't need a warning. A byte can only store numbers up to 256, hence the buffer has to be smaller than that....
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This defines a robust and flexible buffer API which allows the example code to access the buffer functionality in a standard manner irrespective of how the device is actually implementing this functionality.
In this particular request , I have changed the AUTOPOINTER register definition since there seems to be problems when trying to get
#define LOADWORD(reg, value) \ reg ## H = MSB(value); \ reg ## L = LSB(value);Would like to know how you want to proceed.