fix: There is no Stream(gpu, {}) in current thread#3391
fix: There is no Stream(gpu, {}) in current thread#3391kyr0 wants to merge 1 commit intoml-explore:mainfrom
Conversation
|
+1 from a downstream user. Our scoring pipeline lazily imports The auto-register fallback you propose is exactly what would let us drop our |
|
Can you try the new We can not accept the change you proposed because it gives user false impression they are committing to the same queue, which we might want to support in future. |
Proposed changes
This is for quickly discussing the following idea:
Instead of:
When MLX operations in any client application are serialized through a single executor, this is safe. If people use it without serialization... it might break anyways? But for all consumers who build sane, multi-threaded code, this will simply work instead of giving them unnecessary headaches?
I'm wondering what I'm overlooking.
(I tested this with oMLX which had issues with newer versions of mlx - anything above 0.31.1 in my custom fork - and it works flawlessly)
#3078
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes