Add clear_streams API for cleanup before exit#3395
Open
zcbenz wants to merge 1 commit intoml-explore:mainfrom
Open
Add clear_streams API for cleanup before exit#3395zcbenz wants to merge 1 commit intoml-explore:mainfrom
zcbenz wants to merge 1 commit intoml-explore:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows horror story: we should not do anything complicated during thread/process teardown (i.e. in the callbacks registered by system
atexitexplicitly via APIs or implicitly via C++static/thread_localkeywords), joining threads would cause deadlocks, and calling any CUDA API would fail.The solution proposed here is to just provide an API to let users invoke before thread/process exit:
The API call is optional, if users don't use it the program would still work normally on macOS/Linux that everything gets synchronized and cleared implicitly by us, except for Windows where the program would crash on exit, which is actually fine for most cases.