Open
Conversation
Contributor
Author
|
Fixes : #91 |
NaveenMittal0
changed the title
Contributor
Author
Member
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to fix linking issues for aarch64 builds by allowing a custom toolchain to be specified via the TOOLCHAIN_DIR variable. The approach is sound, but I have a couple of suggestions to improve the robustness and maintainability of the CMake script changes.
Member
|
Hi @NaveenMittal0, thanks for your contribution! Would you mind taking a look at the gemini reviews above? |
Contributor
Author
Thanks @MasterJH5574 for the reminder. Its cool that you enabled AI pr review, its great to keep code quality high. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.