-
Notifications
You must be signed in to change notification settings - Fork 34
Add azure support for storing MLRun artifacts #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
GiladShapira94
merged 17 commits into
mlrun:development
from
GiladShapira94:azure-blob-support
Mar 29, 2026
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
a8dd61c
Add mlrun 1.11.0-rc28 tag version
GiladShapira94 7645b2a
Merge remote-tracking branch 'upstream/development' into development
GiladShapira94 c09aeaf
Merge remote-tracking branch 'upstream/development' into development
GiladShapira94 34dab64
Merge remote-tracking branch 'upstream/development' into development
GiladShapira94 9218cd9
Merge remote-tracking branch 'upstream/development' into development
GiladShapira94 d6b284c
Merge remote-tracking branch 'upstream/development' into development
GiladShapira94 d89bf8a
add init container when seaweedfs is enable
GiladShapira94 7197627
change chart version
GiladShapira94 6281b97
fix after review
GiladShapira94 6c2a841
fix after review
GiladShapira94 7f9a9e5
first commit
GiladShapira94 980db1f
Merge remote-tracking branch 'upstream/development' into azure-blob-s…
GiladShapira94 39b6bf9
first commit
GiladShapira94 cdd7aaa
first commit
GiladShapira94 db1a226
first commit
GiladShapira94 1277544
fix after review
GiladShapira94 13d24d2
fix after review
GiladShapira94 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,18 @@ | ||
| {{ if .Values.jupyterNotebook.enabled}} | ||
| {{- $bucket_name := .Values.global.infrastructure.aws.bucketName | default "mlrun" }} | ||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: jupyter-common-env | ||
| data: | ||
| # S3 credentials (AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, AWS_ENDPOINT_URL_S3) | ||
| # are loaded from the 's3-credentials' Secret | ||
| # Storage credentials are loaded from the 'storage-credentials' Secret | ||
| # (AWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEY/AWS_ENDPOINT_URL_S3 for s3, or AZURE_STORAGE_* for azure-blob) | ||
| MLRUN_STORAGE__AUTO_MOUNT_TYPE: {{ .Values.mlrun.storageAutoMountType | default "secret_env" }} | ||
| S3_NON_ANONYMOUS: {{ .Values.global.infrastructure.aws.s3NonAnonymous | toString | title | quote | default "\"True\"" }} | ||
| MLRUN_CE__MODE: {{ .Values.jupyterNotebook.ce.mode | default "full" }} | ||
| MLRUN_CE__VERSION: {{ .Chart.Version }} | ||
| MLRUN_FUNCTION__SPEC__SERVICE_ACCOUNT__DEFAULT: {{ .Values.mlrun.api.functionSpecServiceAccountDefault | default "" | quote }} | ||
| MLRUN_FEATURE_STORE__DATA_PREFIXES__DEFAULT: s3:///{{ $bucket_name }}/projects/{project}/FeatureStore/{name}/{kind} | ||
| MLRUN_HTTPDB__REAL_PATH: {{ include "mlrun-ce.httpdb.realPath" . | quote }} | ||
| MLRUN_STORAGE__AUTO_MOUNT_PARAMS: {{ include "mlrun.storage.auto.mount.params" . }} | ||
| MLRUN_FEATURE_STORE__DATA_PREFIXES__NOSQL: "" | ||
| MLRUN_FEATURE_STORE__DEFAULT_TARGETS: parquet | ||
| MLRUN_HTTPDB__REAL_PATH: s3:// | ||
| {{- end}} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 0 additions & 15 deletions
15
charts/mlrun-ce/templates/config/s3-credentials-secret.yaml
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MLRUN_FEATURE_STORE__DATA_PREFIXES__DEFAULTwas removed here but not replaced. Inmlrun-env-configmap.yamlit's set for both modes (S3 and Azure) inside the if/else block. Since Jupyter uses a separate configmap (jupyter-common-env), it won't inherit that value - I guess it will fall back to MLRun's built-in default which points to v3io://. Should this be added back here for both modes, same as in the MLRun configmap or is it works differently?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is ok, as this values return from MLRun server so it's better to have one source of truth