ENH: Add optional channel name overlay to plot_alignment#13570
Open
aman-coder03 wants to merge 7 commits intomne-tools:mainfrom
Open
ENH: Add optional channel name overlay to plot_alignment#13570aman-coder03 wants to merge 7 commits intomne-tools:mainfrom
aman-coder03 wants to merge 7 commits intomne-tools:mainfrom
Conversation
aman-coder03
requested review from
agramfort,
dengemann,
drammock and
larsoner
as code owners
drammock
reviewed
Jan 2, 2026
Member
There was a problem hiding this comment.
take a look at other files in this directory, to see how they should be formatted (e.g. no heading, and mention the author and PR number)
mne/viz/_3d.py
Outdated
Comment on lines
959
to
961
| xyz[0], | ||
| xyz[1], | ||
| xyz[2], |
Member
There was a problem hiding this comment.
Suggested change
| xyz[0], | |
| xyz[1], | |
| xyz[2], | |
| *xyz, |
Member
|
@aman-coder03 please also look at our tutorials or examples that use |
Author
|
thanks for your suggestion @drammock |
Contributor
|
Hey @aman-coder03, for describing your changes in the changelog you might wanna read this. Also you can ping me if you need any sort of help. |
aman-coder03
force-pushed
the
enh-plot-alignment-channel-names
branch
from
b3694e8 to
3e575f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds an optional
show_channel_namesparameter toplot_alignmentto overlay channel labels at sensor locations in the 3D alignment view.Why?
this improves interpretability when inspecting sensor alignment, especially for debugging, teaching, and demonstrations. The feature is fully opt-in and does not change default behavior.
Backward compatibility
fully backward compatible (disabled by default).
Tests
visualization tests pass (dataset-dependent tests skipped as expected).
fixes #13502