MRG: ENH: Automatically report rejection/flat thresholds in add_epoch…#13617
Open
shamshad-ansari wants to merge 3 commits intomne-tools:mainfrom
Open
MRG: ENH: Automatically report rejection/flat thresholds in add_epoch…#13617shamshad-ansari wants to merge 3 commits intomne-tools:mainfrom
shamshad-ansari wants to merge 3 commits intomne-tools:mainfrom
Conversation
Author
b8ad333 to
9de757b
Compare
Member
|
Was this PR AI-generated? Please disclose the extent of AI usage |
Author
I used an LLM to help draft the retrieval logic. However, I have manually verified the implementation by: Running the existing test suite (pytest mne/report/tests/test_report.py). Verifying the rendered HTML output using a test script (see attached screenshots). Ensuring the code follows the project's style guidelines via ruff. Please let me know if there are specific changes to the logic or formatting you'd like me to make! |
Member
|
Okay we are still deliberating the use of LLMs in contributions, it might take a while to get back to this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


…s (#12396)
Reference issue (if any)
Fixes #12396.
What does this implement/fix?
This PR automatically includes
rejectandflatthresholds in the epochs report whenadd_epochs()is called. Previously, while the report showed which epochs were dropped (the Drop Log), it did not document the specific criteria used to drop them unless the user manually added that information viaadd_html().Now, the report automatically retrieves these values from the
Epochsobject, providing a complete and transparent record of the preprocessing steps.Key Changes:
getattr()to safely retrieverejectandflatdictionaries directly from theepochsinstance.epochs._bad_droppedis True, ensuring the report stays clean for data that hasn't undergone rejection.div_klass="epochs"and<code>tags to match the MNE-Python report aesthetic.Additional information
mne/report/tests/test_report.py(25 passed).ruff.