BUG: Fix bug with fwd.info["dev_head_t"] setting#13619
Open
larsoner wants to merge 3 commits intomne-tools:mainfrom
Open
BUG: Fix bug with fwd.info["dev_head_t"] setting#13619larsoner wants to merge 3 commits intomne-tools:mainfrom
larsoner wants to merge 3 commits intomne-tools:mainfrom
Conversation
larsoner
requested review from
agramfort,
dengemann and
drammock
as code owners
larsoner
changed the title
Member
Author
|
@CarinaFo maybe a good one for you to review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
info['dev_head_t'] is None, we should preserve that rather than fake one by setting it as identity. It's cleaner conceptually and code-wise.... but we almost certainly already have some
fwdsaved to disk with thisinfo["dev_head_t"] = Transform("meg", "head")identity transformation, so let's tweak the problematic check in the simulation code, too.Closes #13604