ENH: allow per-channel colors in raw.plot via channel name dict keys#13765
Open
HansujaB wants to merge 3 commits intomne-tools:mainfrom
Open
ENH: allow per-channel colors in raw.plot via channel name dict keys#13765HansujaB wants to merge 3 commits intomne-tools:mainfrom
HansujaB wants to merge 3 commits intomne-tools:mainfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
drammock
reviewed
Mar 30, 2026
Comment on lines
+333
to
+335
| assert fig2.mne.ch_colors[0] == "red" | ||
| assert fig2.mne.ch_colors[1] == "k" | ||
| assert fig2.mne.ch_colors[2] == "k" |
Member
There was a problem hiding this comment.
this tests whether the figure-attached metadata object mne.ch_colors has the right values. It doesn't confirm that the actual lines on the plot have the right colors. Can you adjust the test to verify that?
Contributor
Author
There was a problem hiding this comment.
@drammock Thanks a lot , I missed this I have added further tests to check plot lines also have right colour. Let me know if anything else needs to be changed I have also added the changelog entry!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12658
What does this implement/fix?
Adds support for per‑channel color overrides in raw.plot by allowing the color dict to be keyed by channel names (with name keys taking precedence over type keys). Updates the docstring and adds a small matplotlib‑only test to verify the behavior.
Additional information
Backwards compatible: existing type‑based color dicts continue to work unchanged.