ENH: expose font_file in brain.add_text (#12543)#13778
Open
PragnyaKhandelwal wants to merge 6 commits intomne-tools:mainfrom
Open
ENH: expose font_file in brain.add_text (#12543)#13778PragnyaKhandelwal wants to merge 6 commits intomne-tools:mainfrom
PragnyaKhandelwal wants to merge 6 commits intomne-tools:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
Fixes #12543.
What does this implement/fix?
This PR exposes a
font_fileparameter inbrain.add_text()and forwards it to the underlying PyVistaadd_text()call.This allows users to pass a
.ttf/.ttcfont file for Unicode glyph rendering (for example, CJK characters and symbols), while preserving current behavior whenfont_fileis not provided.Additional information
Verification context:
font_filein PyVista resolves Unicode rendering foradd_text().