fix: send MSG_DETACH before exit on detach key press#11
Open
DonaldoDes wants to merge 1 commit intomobydeck:mainfrom
Open
fix: send MSG_DETACH before exit on detach key press#11DonaldoDes wants to merge 1 commit intomobydeck:mainfrom
DonaldoDes wants to merge 1 commit intomobydeck:mainfrom
Conversation
When Ctrl+\ was pressed, process_kbd called exit(0) without notifying the master via MSG_DETACH. The master only learned about the detach when it received EOF on the closed fd, introducing a window where a concurrent `atch list` could read the stale S_IXUSR bit and display "[attached]" for a session that was already detached. Send MSG_DETACH synchronously before calling exit(0), mirroring the existing suspend-key (VSUSP) path. This ensures the master clears the S_IXUSR mode bit within one select cycle — before the client exits. Adds regression tests (test 23) exercising the MSG_DETACH → list flow across single and multi-session attach/detach cycles. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MSG_DETACHto the master socket before callingexit(0)inprocess_kbdS_IXUSRsynchronously, soatch listnever shows stale[attached]statusCloses #7
Test plan
🤖 Generated with Claude Code