feat: add list -a flag to show exited sessions#17
Open
ricardovfreixo wants to merge 1 commit intomobydeck:mainfrom
Open
feat: add list -a flag to show exited sessions#17ricardovfreixo wants to merge 1 commit intomobydeck:mainfrom
ricardovfreixo wants to merge 1 commit intomobydeck:mainfrom
Conversation
Scan for .log files without a matching socket and display them with [exited] tag. Allows users to see sessions that ended cleanly but still have replay logs available.
ricardovfreixo
force-pushed
the
feat/list-exited
branch
from
9753ec6 to
7b4d3b2
Compare
Member
|
@ricardovfreixo great addition, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
atch listcurrently only shows running and stale sessions (sockets).logfile but no socket, making them invisibleatch list -aadds a second pass that scans for.logfiles without a matching socket and displays them with[exited]Example
Test plan
atch start test -- sh -c 'echo hello; sleep 1'then wait for exitatch list— should NOT showtestatch list -a— should showtestwith[exited]and correct ageatch test— should replay the log from the exited sessionatch clear testthenatch list -a—testshould disappearatch list -awith no exited sessions — no extra output, same asatch list