Skip to content

fix: resource refresh button now bypasses cache to re-read content #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ctonneslan wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −6
Open

fix: resource refresh button now bypasses cache to re-read content #1155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions client/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -893,8 +893,11 @@ const App = () => {
setPromptContent(JSON.stringify(response, null, 2));
};

const readResource = async (uri: string) => {
if (fetchingResources.has(uri) || resourceContentMap[uri]) {
const readResource = async (uri: string, force: boolean = false) => {
if (fetchingResources.has(uri)) {
return;
}
if (!force && resourceContentMap[uri]) {
return;
}

Expand Down Expand Up @@ -1471,9 +1474,9 @@ const App = () => {
setResourceTemplates([]);
setNextResourceTemplateCursor(undefined);
}}
readResource={(uri) => {
readResource={(uri, force) => {
clearError("resources");
readResource(uri);
readResource(uri, force);
}}
selectedResource={selectedResource}
setSelectedResource={(resource) => {
Expand Down
4 changes: 2 additions & 2 deletions client/src/components/ResourcesTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ const ResourcesTab = ({
clearResources: () => void;
listResourceTemplates: () => void;
clearResourceTemplates: () => void;
readResource: (uri: string) => void;
readResource: (uri: string, force?: boolean) => void;
selectedResource: Resource | null;
setSelectedResource: (resource: Resource | null) => void;
handleCompletion: (
Expand Down Expand Up @@ -229,7 +229,7 @@ const ResourcesTab = ({
<Button
variant="outline"
size="sm"
onClick={() => readResource(selectedResource.uri)}
onClick={() => readResource(selectedResource.uri, true)}
>
<RefreshCw className="w-4 h-4 mr-2" />
Refresh
Expand Down