Skip to content

fix: remove Content-Type header from OAuth metadata discovery GET requests #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MumuTW wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −6
Open

fix: remove Content-Type header from OAuth metadata discovery GET requests #1157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions client/src/lib/hooks/useConnection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,16 +582,22 @@ export function useConnection({
switch (transportType) {
case "sse":
requestHeaders["Accept"] = "text/event-stream";
requestHeaders["content-type"] = "application/json";
transportOptions = {
authProvider: serverAuthProvider,
fetch: async (
url: string | URL | globalThis.Request,
init?: RequestInit,
) => {
const mergedHeaders = { ...requestHeaders };
// Only set Content-Type on requests with a body (e.g. POST).
// GET requests (such as OAuth metadata discovery) must not
// include Content-Type, as some servers reject it with 415.
if (init?.body) {
mergedHeaders["content-type"] = "application/json";
}
const response = await fetch(url, {
...init,
headers: requestHeaders,
headers: mergedHeaders,
});

// Capture protocol-related headers from response
Expand All @@ -611,11 +617,16 @@ export function useConnection({
url: string | URL | globalThis.Request,
init?: RequestInit,
) => {
requestHeaders["Accept"] =
"text/event-stream, application/json";
requestHeaders["Content-Type"] = "application/json";
const mergedHeaders = { ...requestHeaders };
mergedHeaders["Accept"] = "text/event-stream, application/json";
// Only set Content-Type on requests with a body (e.g. POST).
// GET requests (such as OAuth metadata discovery) must not
// include Content-Type, as some servers reject it with 415.
if (init?.body) {
mergedHeaders["Content-Type"] = "application/json";
}
const response = await fetch(url, {
headers: requestHeaders,
headers: mergedHeaders,
...init,
});

Expand Down
Loading