feat: add SSE reconnection with retry support #596
+531
−64
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,4 +11,3 @@ server: | |
|
|
||
| client: | ||
| - elicitation-sep1034-client-defaults | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| package io.modelcontextprotocol.kotlin.sdk.client | ||
|
|
||
| import kotlin.time.Duration | ||
| import kotlin.time.Duration.Companion.seconds | ||
|
|
||
| /** | ||
| * Options for controlling SSE reconnection behavior. | ||
| * | ||
| * @property initialReconnectionDelay The initial delay before the first reconnection attempt. | ||
| * @property maxReconnectionDelay The maximum delay between reconnection attempts. | ||
| * @property reconnectionDelayMultiplier The factor by which the delay grows on each attempt. | ||
| * @property maxRetries The maximum number of reconnection attempts per disconnect. | ||
| */ | ||
| public class ReconnectionOptions( | ||
| public val initialReconnectionDelay: Duration = 1.seconds, | ||
| public val maxReconnectionDelay: Duration = 30.seconds, | ||
| public val reconnectionDelayMultiplier: Double = 1.5, | ||
| public val maxRetries: Int = 2, | ||
| ) { | ||
| override fun equals(other: Any?): Boolean { | ||
|
Contributor
There was a problem hiding this comment. why don't use data class for this? to avoid manual hashCode/equals, and also it gives you the pattern options.copy([only specific fields])
Contributor
Author
There was a problem hiding this comment. Data classes are indeed more convenient the problem is that any changes to them can introduce binary incompatibility in the future |
||
| if (this === other) return true | ||
| if (other == null || this::class != other::class) return false | ||
|
|
||
| other as ReconnectionOptions | ||
|
|
||
| if (reconnectionDelayMultiplier != other.reconnectionDelayMultiplier) return false | ||
| if (maxRetries != other.maxRetries) return false | ||
| if (initialReconnectionDelay != other.initialReconnectionDelay) return false | ||
| if (maxReconnectionDelay != other.maxReconnectionDelay) return false | ||
|
|
||
| return true | ||
| } | ||
|
|
||
| override fun hashCode(): Int { | ||
|
Contributor
There was a problem hiding this comment. the hashCode() ordering doesn't match the equals() ordering (reconnectionDelayMultiplier first vs. last), which is a style inconsistency even if not a correctness bug. |
||
| var result = reconnectionDelayMultiplier.hashCode() | ||
| result = 31 * result + maxRetries | ||
| result = 31 * result + initialReconnectionDelay.hashCode() | ||
| result = 31 * result + maxReconnectionDelay.hashCode() | ||
| return result | ||
| } | ||
|
|
||
| override fun toString(): String = | ||
| "ReconnectionOptions(initialReconnectionDelay=$initialReconnectionDelay, maxReconnectionDelay=$maxReconnectionDelay, reconnectionDelayMultiplier=$reconnectionDelayMultiplier, maxRetries=$maxRetries)" | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is also advantageous to have a jitter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea, will consider in follow-up