chore: #608 update kotlin and kotlinx versions#611
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the build toolchain and Kotlin ecosystem dependencies across the root project and standalone Gradle sample builds, primarily by bumping the Gradle wrapper and shared version-catalog entries.
Changes:
- Bump Gradle wrapper from 9.3.1 to 9.4.0 (root + samples).
- Update Kotlin to 2.3.20 and refresh several Kotlin ecosystem dependencies (Ktor, kotlinx-io, kotlinx-serialization, etc.) in version catalogs.
- Update sample-specific version catalogs (e.g., mcp-kotlin, shadow, anthropic) to keep samples building with current dependencies.
Reviewed changes
Copilot reviewed 15 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| samples/weather-stdio-server/gradlew | Gradle wrapper script regenerated for 9.4.0. |
| samples/weather-stdio-server/gradle/wrapper/gradle-wrapper.properties | Points sample wrapper distribution to Gradle 9.4.0. |
| samples/weather-stdio-server/gradle/wrapper/gradle-wrapper.jar | Updates the checked-in wrapper JAR for the sample. |
| samples/weather-stdio-server/gradle/libs.versions.toml | Bumps Kotlin/Ktor/logging/shadow versions for the sample. |
| samples/simple-streamable-server/gradlew | Gradle wrapper script regenerated for 9.4.0. |
| samples/simple-streamable-server/gradle/wrapper/gradle-wrapper.properties | Points sample wrapper distribution to Gradle 9.4.0. |
| samples/simple-streamable-server/gradle/libs.versions.toml | Bumps Kotlin/Ktor/shadow versions for the sample. |
| samples/kotlin-mcp-server/gradlew | Gradle wrapper script regenerated for 9.4.0. |
| samples/kotlin-mcp-server/gradle/wrapper/gradle-wrapper.properties | Points sample wrapper distribution to Gradle 9.4.0. |
| samples/kotlin-mcp-server/gradle/libs.versions.toml | Bumps Kotlin/Ktor/mcp-kotlin/shadow versions for the sample. |
| samples/kotlin-mcp-client/gradlew | Gradle wrapper script regenerated for 9.4.0. |
| samples/kotlin-mcp-client/gradle/wrapper/gradle-wrapper.properties | Points sample wrapper distribution to Gradle 9.4.0. |
| samples/kotlin-mcp-client/gradle/libs.versions.toml | Bumps anthropic + Kotlin/Ktor/shadow versions for the sample. |
| gradlew.bat | Regenerated/normalized Gradle Windows wrapper script. |
| gradlew | Gradle wrapper script regenerated for 9.4.0. |
| gradle/wrapper/gradle-wrapper.properties | Points root wrapper distribution to Gradle 9.4.0. |
| gradle/wrapper/gradle-wrapper.jar | Updates the checked-in root wrapper JAR. |
| gradle/libs.versions.toml | Updates root version catalog (Kotlin/Ktor/kotlinx-io/serialization/logging). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
Updates the Gradle wrapper and Kotlin ecosystem dependency versions across the root build and the standalone samples/* Gradle builds to keep the repo aligned with newer Kotlin/Ktor/kotlinx releases.
Changes:
- Bump Gradle wrapper distribution from 9.3.1 to 9.4.0 (root + samples), including wrapper scripts/jars.
- Bump Kotlin to 2.3.20 and Ktor to 3.3.3 across version catalogs (root + samples).
- Bump kotlinx-io and kotlinx-serialization versions in the root version catalog (plus additional version catalog bumps in samples).
Reviewed changes
Copilot reviewed 15 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| samples/weather-stdio-server/gradlew | Regenerated Gradle start script reference for wrapper update. |
| samples/weather-stdio-server/gradle/wrapper/gradle-wrapper.properties | Updates sample wrapper distribution URL to Gradle 9.4.0. |
| samples/weather-stdio-server/gradle/wrapper/gradle-wrapper.jar | Updates sample wrapper JAR content. |
| samples/weather-stdio-server/gradle/libs.versions.toml | Bumps Kotlin/Ktor/Shadow/logging versions for the weather sample. |
| samples/simple-streamable-server/gradlew | Regenerated Gradle start script reference for wrapper update. |
| samples/simple-streamable-server/gradle/wrapper/gradle-wrapper.properties | Updates sample wrapper distribution URL to Gradle 9.4.0. |
| samples/simple-streamable-server/gradle/libs.versions.toml | Bumps Kotlin/Ktor/Shadow versions for the streamable sample. |
| samples/kotlin-mcp-server/gradlew | Regenerated Gradle start script reference for wrapper update. |
| samples/kotlin-mcp-server/gradle/wrapper/gradle-wrapper.properties | Updates sample wrapper distribution URL to Gradle 9.4.0. |
| samples/kotlin-mcp-server/gradle/libs.versions.toml | Bumps Kotlin/Ktor/mcp-kotlin/Shadow versions for the server sample. |
| samples/kotlin-mcp-client/gradlew | Regenerated Gradle start script reference for wrapper update. |
| samples/kotlin-mcp-client/gradle/wrapper/gradle-wrapper.properties | Updates sample wrapper distribution URL to Gradle 9.4.0. |
| samples/kotlin-mcp-client/gradle/libs.versions.toml | Bumps Kotlin/Ktor/Shadow and anthropic client versions for the client sample. |
| gradlew.bat | Wrapper script updated/regenerated (formatting/line ending normalization). |
| gradlew | Regenerated Gradle start script reference for wrapper update. |
| gradle/wrapper/gradle-wrapper.properties | Updates root wrapper distribution URL to Gradle 9.4.0. |
| gradle/wrapper/gradle-wrapper.jar | Updates root wrapper JAR content. |
| gradle/libs.versions.toml | Bumps Kotlin/Ktor/kotlinx-io/serialization and logging versions in the root version catalog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kpavlov
left a comment
There was a problem hiding this comment.
Let's avoid upgrading tooling and dependencies in a single PR: while some changes are fine, others are questionable.
Let's upgrade Kotlin and Ktor separately, after confirming that it is safe.
gradle/libs.versions.toml
Outdated
| detekt = "2.0.0-alpha.2" | ||
| dokka = "2.1.0" | ||
| kotlin = "2.2.21" | ||
| kotlin = "2.3.20" |
There was a problem hiding this comment.
This might be a breaking change. Did you confirm that at least our internal users are not affected?
There was a problem hiding this comment.
Did you confirm that at least our internal users are not affected?
yes
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.4.0-bin.zip |
There was a problem hiding this comment.
do u think update it on this pr?
or dependabot pr?
| mcp-kotlin = "0.9.0" | ||
| slf4j = "2.0.17" | ||
| shadow = "9.2.2" | ||
| shadow = "9.4.0" |
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.4.0-bin.zip |
bumps:
Breaking Changes
Types of changes
Checklist
Additional context
Unfortunately, CodeQL does not yet support the latest version of Kotlin
Colses #608