Add protocol version negotiation to server initialization #223
+117
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duboff
force-pushed
the
md-protocol-negotiation
branch
from
92a0880 to
3c3f0d5
Compare
duboff
force-pushed
the
md-protocol-negotiation
branch
from
3c3f0d5 to
1c14f65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently server launched enforces the latest protocol regardless of the protocols supported by the client. This leads to issues when a client (eg. Claude Desktop) supports only protocol versions (2025-06-18) behind the current version supported by the server (2025-11-25).
This PR adds full protocol version negotiation logic (as per the MCP Spec), including dropping parameters not supported by each individual protocol version, to maximize compatibility.
How Has This Been Tested?
Tested with the Chattermill MCP (proprietary).
Breaking Changes
No breaking changes expected.
Types of changes
Checklist
Additional context
A potential consideration could be to add a config option to enumerate supported protocols if the server developer wants to explicitly avoid supporting all possible protocols. Not implemented here as doesn't seem necessary.