Rename session[:stream] to session[:get_sse_stream]#296
Merged
koic merged 1 commit intomodelcontextprotocol:mainfrom Apr 5, 2026
Merged
Rename session[:stream] to session[:get_sse_stream]#296koic merged 1 commit intomodelcontextprotocol:mainfrom
session[:stream] to session[:get_sse_stream]#296koic merged 1 commit intomodelcontextprotocol:mainfrom
Conversation
Follow-up to modelcontextprotocol#294. The generic `:stream` key does not convey that it refers to the GET SSE stream, making it harder to distinguish from `session[:post_request_streams]` introduced in modelcontextprotocol#294.
atesgoral
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Follow-up to #294.
The generic
:streamkey does not convey that it refers to the GET SSE stream, making it harder to distinguish fromsession[:post_request_streams]introduced in #294.How Has This Been Tested?
Ensure existing tests pass.
Breaking Changes
None.
Types of changes
Checklist
Additional context